-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show backup/restore progress in NAB/NAR status #1649
fix: Show backup/restore progress in NAB/NAR status #1649
Conversation
Signed-off-by: Mateus Oliveira <[email protected]>
This PR and migtools/oadp-non-admin#237 tested on OCP 4.19 worked for me.. see my updates in 237 :) |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold Actually there is one unresolved comment which may change this: |
/test 4.16-e2e-test-aws |
Signed-off-by: Mateus Oliveira <[email protected]>
/lgtm |
/unhold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test 4.18-e2e-test-aws |
/test 4.14-e2e-test-aws |
/retest |
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Why the changes were made
migtools/oadp-non-admin#237
How to test the changes made
Follow instructions on NAC PR migtools/oadp-non-admin#239